wxFrameManager doesn't skip mouse move or button up

[gerryiles]

The wxFrameManager class takes care to call event.Skip() for left button down events that it doesn't handle but doesn't do the same for left button up or mouse move events. This causes problems if you need to capture the mouse in the frame class.

This patch should sort it out:

--- Trunk/XaraLX/wxXtra/manager.cpp (revision 627)
+++ Trunk/XaraLX/wxXtra/manager.cpp (revision 628)
@@ -4049,6 +4049,10 @@
pane.state &= ~wxPaneInfo::actionPane;
Update();
}
+ else
+ {
+ event.Skip();
+ }

m_action = actionNone;
m_last_mouse_move = wxPoint(); // see comment in OnMotion()
@@ -4198,6 +4202,10 @@
m_hover_button = NULL;
Repaint();
}
+ else
+ {
+ event.Skip();
+ }
}
}
}

Gerry
Senior Programmer, Xara Group Ltd.

[abligh]

The wxFrameManager class takes care to call event.Skip() for left button down events that it doesn't handle but doesn't do the same for left button up or mouse move events. This causes problems if you need to capture the mouse in the frame class.

This patch should sort it out:

This, and the fix for IdleEvents, are now up at http://www.alex.org.uk/wxAUI/index,html