jason's fix

[HzD_Byte]

bwilliams, please apply jason's fix:

I believe I have a fix.

Change the check for actionDragFloatingPane in
void wxFrameManager::OnMotion(wxMouseEvent& event) to:

else if (m_action == actionDragFloatingPane)
{
if (m_action_window == NULL)
setAction(actionNone);
else {
wxPoint pt = m_frame->ClientToScreen(event.GetPosition());
m_action_window->Move(pt.x - m_action_offset.x,
pt.y - m_action_offset.y);
}
}

Add the check to set m_action_window to NULL in
void wxFrameManager::Update()

// reduce flicker
p.window->SetSize(1,1);

if (p.frame->IsShown())
p.frame->Show(false);

if (m_action_window == p.frame)
m_action_window = NULL;

[Ben]

Hello,

Are you using the wxWidgets CVS version of wxAUI? This bug was fixed in a slightly different way. If you are using wxAUI 0.9.x, one way to fix the problem is jason's patch, but ultimately, that's not what was causing the race condition (at least for me).

If you are still having problems, I'll apply the patch as it is listed here.

Thanks,
Ben

[jason]

In what CVS file revision was this fixed?

[Ben]

Hi there,

In framemanager.cpp version 1.46. It turned out that calling Show() was firing window move events which were causing this problem.

Did the problem go away for you after upgrading?

Best,
Ben

[HzD_Byte]

bwilliams, i'm using CVS version...

this bug is still here
(when moving panes, sometimes)

and a new bug: sometimes there is no way to dock floating pane.. (this thing appeared recently)

[jason]

I've just compiled from a 2006-09-30 CVS snapshot, and the problem is still there. I can repeatedly produce the problem by creating an app with a single window and docking it back and forth between two opposing sides of the application's main window.


I do not think the fix I gave is correct since with it floating panes sometimes stop reponding to mouse drags.

I will work on this more today.

[tierra]

Just replying to reference a related patch on the wxWidgets bug tracker: #1575571

[Ben]

Hi all,

I just fixed the problem. Let me know if it still happens for you, though I don't think it will.

Best,
Ben