BUG - [ 1834906 ] wxAssertFailure wxEVT_MOUSE_CAPTURE_LOST

[NinjaNL]

auibook.h - line 475 add text

Code: Select all

   void OnCaptureLost(wxMouseCaptureLostEvent& event);

auibook.cpp - line 2191 add text

Code: Select all

    EVT_MOUSE_CAPTURE_LOST(wxAuiTabCtrl::OnCaptureLost)

auibook.cpp - line +- 2625 add text

Code: Select all

void wxAuiTabCtrl::OnCaptureLost(wxMouseCaptureLostEvent&
WXUNUSED(event))
{
}

This simply creates a "placeholder" for the event, which removes the error generated, since the AUINotebook now handles the event. (OK it's about as useful as a damp rag but it solves the problem)

HTH
Mal

[NinjaNL]

Code: Select all

Index: include/wx/aui/auibook.h
===================================================================
--- include/wx/aui/auibook.h   (revision 50326)
+++ include/wx/aui/auibook.h   (working copy)
@@ -474,6 +474,7 @@
     void OnSetFocus(wxFocusEvent& event);
     void OnKillFocus(wxFocusEvent& event);
     void OnChar(wxKeyEvent& event);
+   void OnCaptureLost(wxMouseCaptureLostEvent& event);

protected:

Index: src/aui/auibook.cpp
===================================================================
--- src/aui/auibook.cpp   (revision 50326)
+++ src/aui/auibook.cpp   (working copy)
@@ -2186,6 +2186,7 @@
     EVT_SET_FOCUS(wxAuiTabCtrl::OnSetFocus)
     EVT_KILL_FOCUS(wxAuiTabCtrl::OnKillFocus)
     EVT_CHAR(wxAuiTabCtrl::OnChar)
+    EVT_MOUSE_CAPTURE_LOST(wxAuiTabCtrl::OnCaptureLost)
END_EVENT_TABLE()


@@ -2619,6 +2620,11 @@
         event.Skip();
}

+void wxAuiTabCtrl::OnCaptureLost(wxMouseCaptureLostEvent& WXUNUSED(event))
+{
+}
+
+
// wxTabFrame is an interesting case.  It's important that all child pages
// of the multi-notebook control are all actually children of that control
// (and not grandchildren).  wxTabFrame facilitates this.  There is one


[Ben]

How do I reproduce the problem?

Thanks much,
Ben

[NinjaNL]

http://sourceforge.net/tracker/index.php?func=detail&aid=1834906&group_id=9863&atid=109863

Basically it is a debug build, add an event handler for AUI Notebook Page Changed event, and in the handler add the following code

Code: Select all

wxMessageDialog dialog(this,_T("This is an error"),_T("Error"),wxOK);
dialog.ShowModal();<-----happens here


The first time there is a notebook page change you should get the wxAssertFailure message.

The fix simply adds a handler (that swallows the event). Now whenever the wxEVT_MOUSE_CAPTURE_LOST event is fired, it is handled, so wxWidgets no longer generates the assert.

Best
Mal

[Ben]

Wonderful. Thanks for the report.

Best,
Ben

[Ben]

Patch applied to 2.8 and trunk. Thanks.